This repository has been archived by the owner on Oct 31, 2023. It is now read-only.
Docker stats POC #4862
Closed
Docker stats POC #4862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maaktweluit
suggested changes
Nov 7, 2019
| f'Memory: {(mem / 1024 / 1024):.3f} MiB') | ||
| except KeyError: | ||
| # The last message in the stream usually raises KeyError | ||
| print('Wrong stats format') |
There was a problem hiding this comment.
maybe add if status == running here to, so it can be an "error" while running and a info ( or no message ) when its not
There was a problem hiding this comment.
Nice idea.
However, I'm not sure if the last message is sent after the container is stopped or just before. Need to check it.
maaktweluit
approved these changes
Nov 7, 2019
Codecov Report
@@ Coverage Diff @@
## develop #4862 +/- ##
===========================================
+ Coverage 89.2% 90.11% +0.91%
===========================================
Files 231 231
Lines 21263 21250 -13
===========================================
+ Hits 18967 19150 +183
+ Misses 2296 2100 -196 |
|
Merged in #4901 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run e.g.
Should print something like this:
Hit CTRL+C to stop.